https://bugzilla.redhat.com/show_bug.cgi?id=1272248 Jan Chaloupka <jchaloup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #18 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- > If I create a _vendor directory inside the heketi-{ver}.tar.gz file, wouldn't > it have to be then created by someone other than the developer since the repo > will not have this direstory? With some automatic scripting it could be created in heketi's repository automatically with every update of glockfile. That was my thought. > Could gofed create the godeps directory and add it inside the tar file for > those programs that do not include it in their repo and instead use glock? I could script it, actually it is a good idea. There is a lot of projects without Godeps/vendor directory suited for this use case. I really like the first option :). Let's do it. Meantime the bundled(...) list can be generated from GLOCKFILE. As long as the package is built from dependencies in Fedora, there is no need for bundled list. So right now the spec file conforms to the current packaging guidelines for go. Approving the spec file. Still, please generate the bundled list under a BuildRequires of main package with: %if 0%{?with_bundled} && 0%{?fedora} Provides: bundled... ... %endif This policy is currently only for Fedora. Thanks for the discussion. [1] https://github.com/gofed/gofed/issues/66 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review