https://bugzilla.redhat.com/show_bug.cgi?id=1265992 Michal Ambroz <rebus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Michal Ambroz <rebus@xxxxxxxxx> --- >> [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file >i do not understand what is this ... Please ignore - I forgot to delete that one. It is from my mockbuild >Maybe qpid-jms sub package should be renamed qpid-jms-parent ...? Maybe. I leave this on your preference. There is nothing about that in https://fedoraproject.org/wiki/Packaging:Java. Checking the yum repository, the majority of the packages containing the parent.xml is indeed named as "%{name}-parent", however there are packages like apacheds, hibernate or guice-extensions, which do not follow this naming. yum provides '/usr/share/maven-metadata/*-parent.xml' >From my side - review complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review