[Bug 1273141] Review Request: nodejs-sprintf-js - JavaScript sprintf implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1273141



--- Comment #3 from Tom Hughes <tom@xxxxxxxxxx> ---
Tests are already in the npmjs tar ball so there doesn't seem to be any need
for the extra file.

You also need to consider what you're packaging - you are including
gruntfile.js (a build tool) but not the src directory, which includes the
actual main entry point declared in package.json.

If dist is going to be included then uglify should probably be run in %build to
build it from src.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]