https://bugzilla.redhat.com/show_bug.cgi?id=1250833 --- Comment #11 from Michael Schwendt <bugs.michael@xxxxxxx> --- Good. Some more advanced topics: > License: GPLv3 The source files say "or later", which would be "GPLv3+": https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses > ExcludeArch: armv7hl https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures > Requires: lv2 # dnf list lv2|grep ^lv lv2.i686 1.10.0-2.fc22 fedora lv2.x86_64 1.10.0-2.fc22 fedora As you're shipping files in %{_libdir}/lv2/helm.lv2/ you want to make this explicit dependency arch-specific via %{?_isa}: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > %{_datadir}/applications/helm.desktop /builddir/build/SOURCES/helm.desktop: warning: key "Categories" is a list and does not have a semicolon as trailing character, fixing /builddir/build/BUILDROOT/helm-0.5.0-2.fc24.x86_64/usr/share/applications/helm.desktop: warning: value "Software Synthesizer" for key "Comment" in group "Desktop Entry" looks redundant with value "Software Synthesizer" of key "GenericName" > %{_datadir}/applications/helm.desktop https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files > helm-0.5.0/JUCE/ That is a bundled library from juce.com and makes the package non-trivial. The No_Bundled_Libraries policy has been changed recently, and the controversial change is still being discussed: https://fedoraproject.org/w/index.php?title=Packaging:No_Bundled_Libraries&oldid=406058 > helm-0.5.0/mopo/ Dunno whether the author has released this independently yet (apart from https://github.com/mtytel/mopo ) or only together with Helm. Not an issue yet. > helm-0.5.0/fonts/ $ grep ttf build.log $ Also don't appear in the packages. > /usr/share/helm/patches/LICENSE That's not GPLv3, and this file in the helm-common package is not marked %license either. This is some Creative Commons Attribution 4.0 license. Note that each (sub-)package can have its own Group tag: https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing > rpmlint It finds some things when running it on all the built packages. > Unknown It GNOME Shell (Fedora 22), the application /usr/bin/helm creates a shell menu entry with the name "Unknown". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review