https://bugzilla.redhat.com/show_bug.cgi?id=1272248 --- Comment #16 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- One one hand creating vendor directory adds responsibility to update the directory at the same time you regenerate GLOCKFILE. On the other separating godeps from the project itself adds responsibility on maintainer of the package in Fedora not to forget to update the godeps.tar.gz file. I would choose the former. It simplifies the spec file and it is common to provide such directory. In both cases, if you build you package from bundled deps, you must provide a list of bundled dependencies [1]: "All packages whose upstreams have no mechanism to build against system libraries may opt to carry bundled libraries, but if they do, they must include Provides: bundled(<libname>) = <version> in their RPM spec file." If a file with dependencies is provided, it makes sense to replace <version> with a version which would be provided if the dependency would be packaged in Fedora. However, usually there is no version. Maybe something like %{version}-%{shortcommit} could be used instead. I have opened RFE for it [2]. What do you think about it, Luis? [1] https://fedorahosted.org/fesco/ticket/1483#comment:17 [2] https://github.com/gofed/gofed/issues/42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review