[Bug 1265992] Review Request: qpid-jms - AMQP Java Message Service Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1265992



--- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Michal Ambroz from comment #3)
> Hello,
> the only thing I am not sure are the dependencies between the package and
> sub-packages. I would assume that the
> qpid-jms-examples-0.6.0-1.fc24.noarch.rpm would require
> qpid-jms-0.6.0-1.fc24.noarch.rpm and possibly
> qpid-jms-client-0.6.0-1.fc24.noarch.rpm in order to be usefull.
> Please can you check / explain?
> 
> Thank you

Thanks to you!
Requirement list are generate by our Java tools:
as you can see below qpid-jms-examples require only qpid-jms-client. Maybe
qpid-jms sub package should be renamed qpid-jms-parent ...?
e.g.

- %files -f .mfiles-%{name}-parent
- %doc README.md
- %license LICENSE NOTICE
- 
%files client -f .mfiles-%{name}-client
- %doc %{name}-docs/Configuration.md
+ %doc README.md %{name}-docs/Configuration.md
%license LICENSE NOTICE

%files examples -f .mfiles-%{name}-examples
%doc %{name}-examples/README.txt
%license LICENSE NOTICE

+ %files parent -f .mfiles-%{name}-parent
+ %license LICENSE NOTICE

> Requires
> --------
> qpid-jms (rpmlib, GLIBC filtered):
>     java-headless
>     jpackage-utils
>     mvn(org.apache.maven.plugins:maven-compiler-plugin)
>     mvn(org.apache.rat:apache-rat-plugin)
>     mvn(org.apache:apache:pom:)
> 
> qpid-jms-client (rpmlib, GLIBC filtered):
>     java-headless
>     jpackage-utils
>     mvn(io.netty:netty-all)
>     mvn(org.apache.geronimo.specs:geronimo-jms_1.1_spec)
>     mvn(org.apache.qpid:proton-j)
>     mvn(org.slf4j:slf4j-api)
> 
> qpid-jms-examples (rpmlib, GLIBC filtered):
>     java-headless
>     jpackage-utils
>     mvn(org.apache.qpid:qpid-jms-client)
>     mvn(org.slf4j:slf4j-log4j12)
> 
> qpid-jms-discovery (rpmlib, GLIBC filtered):
>     java-headless
>     jpackage-utils
>     mvn(org.apache.qpid:qpid-jms-client)
>     mvn(org.slf4j:slf4j-api)

> Provides
> --------
> qpid-jms:
>     mvn(org.apache.qpid:qpid-jms-parent:pom:)
>     qpid-jms
> 
> qpid-jms-client:
>     mvn(org.apache.qpid:qpid-jms-client)
>     mvn(org.apache.qpid:qpid-jms-client:pom:)
>     qpid-jms-client
> 
> qpid-jms-examples:
>     mvn(org.apache.qpid:qpid-jms-examples)
>     mvn(org.apache.qpid:qpid-jms-examples:pom:)
>     qpid-jms-examples
> 
> qpid-jms-discovery:
>     mvn(org.apache.qpid:qpid-jms-discovery)
>     mvn(org.apache.qpid:qpid-jms-discovery:pom:)
>     qpid-jms-discovery


> 
> Package Review
> ==============

> ===== SHOULD items =====
> 
> Generic:
> [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>      Note: Found : Packager: Michal Ambroz <rebus at, seznam.cz>
>      See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
i do not understand what is this ...


> [?]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qpid-
>      jms-client , qpid-jms-discovery , qpid-jms-examples , qpid-jms-javadoc
NOT needed for a noarch package

> [-]: %check is present and all tests pass.
Missing dependecies, is not possible run test suite/s

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]