[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=709328

Raphael Groner <projects.rg@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #157 from Raphael Groner <projects.rg@xxxxxxxx> ---
It looks now good to me. APPROVED

Please be aware about the following, did you forget to upload new spec file?

[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).

Diff spec file in url and in SRPM
---------------------------------
--- /home/builder/fedora-review/709328-psi-plus/srpm/psi-plus.spec   
2015-10-20 13:23:30.707744057 +0200
+++ /home/builder/fedora-review/709328-psi-plus/srpm-unpacked/psi-plus.spec   
2015-10-20 04:50:22.000000000 +0200
@@ -91,12 +91,4 @@
 This package adds internationalization to Psi+.

-%package        common
-Summary:        Noarch resources for Psi+
-BuildArch:      noarch
-
-%description    common
-Psi+ - Psi IM Mod by psi-dev@xxxxxxxxxxxxxxxxxxxx
-This package contains huge of base mandatory resources for Psi+.
-
 %package        plugins
 Summary:        Plugins pack for Psi+
@@ -106,6 +98,12 @@
 License:        GPLv2+ and BSD and Beerware
 Requires:       %{name}%{?_isa} = %{epoch}:%{version}-%{release}
-# Filter out plugins from provides
-%global __provides_exclude_from ^%{_libdir}/psi-plus
+
+%package        common
+Summary:        Noarch resources for Psi+
+BuildArch:      noarch
+
+%description    common
+Psi+ - Psi IM Mod by psi-dev@xxxxxxxxxxxxxxxxxxxx
+This package contains huge of base mandatory resources for Psi+.


@@ -380,5 +378,4 @@
 * Tue Oct 20 2015 Ivan Romanov <drizt@xxxxxxx> - 1:0.16-0.20.20141205git440
 - set correct plugins permissions
-- Filter out plugins from provides

 * Mon Oct 19 2015 Ivan Romanov <drizt@xxxxxxx> - 1:0.16-0.19.20141205git440

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]