[Bug 1272248] Review Request: heketi - RESTful based volume management framework for GlusterFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1272248



--- Comment #12 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
Add) %if 0%{?with_check} && ! 0%{?with_bundled}

Nice! Applied in specfile generator, thanks.

Add) go test -v %{import_path}/apps/glusterfs

Purpose of %gotest macro is portability to secondary architectures where gcc-go
is used instead of gc. On golang architectures, %gotest is defined as "go test
...". On gcc-go it is defined as "go test -compiler gcc-go ...". If you are
targeting primary architectures, it is fine. For secondary, please use %gotest
macro instead and define %gotest macro in %check section before the first use
of %gotest as:

%if ! 0%{?gotest:1}
%global gotest go test
%endif

Otherwise the rest looks fine. Thanks Luis for your feedback on gofed. I have
learnt new things from you.

Jan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]