[Bug 1223990] Review Request: openssl101e - A general purpose cryptography library with TLS implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1223990



--- Comment #10 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> ---
(In reply to Andrew Beekhof from comment #9)
> - rpmlint is wanting the %changelog version to be '1.0.1e-4.el5.centos'

This only happens as long as mock uses CentOS rather RHEL (while official
EPEL builds happen against RHEL), so this disappears by itself.

> - drop /usr/share/doc/openssl101e-1.0.1e/INSTALL

Done.

> - is c_rehash101e necessary?  is there any case where it should be used
> over c_rehash? perhaps drop it (which would take care of the
> no-manual-page-for-binary) warning.

Everything that uses openssl101e should use c_rehash101e, too. Background:
With OpenSSL 1.0.0 the old-style hashing using MD5 was changed to SHA-1.
But as usually both OpenSSL versions are around, c_rehash101e creates links
in old and current style by default (to avoid breaking compatibility).
However, before OpenSSL 1.0.2 there is no man page for c_rehash anyway in
upstream sources (= no man page for c_rehash in RHEL/CentOS 6).

> With the above changes I would claim this package meets the requirements.

Anything else left? Given the only change is now the removal of INSTALL
from %doc, do you need an updated package or would it be fine to perform
this minor change after import into VCS (but before building, thus this
gets trackable)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]