Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: loki-lib - Loki C++ Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243109 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-09 14:53 EST ------- I took a quick look at this. It builds ok in mock on rawhide; here's what rpmlint says: W: loki-lib unused-direct-shlib-dependency /usr/lib64/libloki.so.0.1.6 /lib64/libpthread.so.0 W: loki-lib unused-direct-shlib-dependency /usr/lib64/libloki.so.0.1.6 /lib64/libm.so.6 Now, the makefile explicitly adds -lpthread on linux; I can only assume they do this because it's required in some way. This library does seem to wrap pthread functions but perhaps they aren't directly called. In any case I don't really understand enough to decide whether this is a problem. I don't know where the link against libm comes from; I don't see it specified anywhere. There's a test suite in the package, but it requires that you do a static compile and even then it doesn't actually seem to work. You might want to make a comment about that in the spec (or perhaps investigate and see if you can make it work). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review