[Bug 1270630] Review Request: valabind - Review Request: valabind - Transform vala or vapi files into swig, C++, NodeJS-ffi, or GIR - Unretiring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1270630

Michal Ambroz <rebus@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |puntogil@xxxxxxxxx



--- Comment #1 from Michal Ambroz <rebus@xxxxxxxxx> ---
Comments from the devel list:
From: gil <puntogil@xxxxxxxxx>
Hi

1) maybe you should open a bug for review the package ... ?
2) you must use %license macro for LICENSE text file
3) maybe you could remove %{!?_pkgdocdir: %global 
%{_docdir}/%{name}-%{version}}
    i do not understand why _pkgdocdir is versioned
4) you could remove also "Group:          Applications/Engineering" is no more
required

regards
gil

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]