https://bugzilla.redhat.com/show_bug.cgi?id=1272652 --- Comment #2 from Antonio Trande <anto.trande@xxxxxxxxx> --- Hi Richard. (In reply to Richard Shaw from comment #1) > Quick spec review first: > > 1. Location of Summary tag is weird but not a problem. Yep. I will move it in a "traditional" location. > > 2. Group tags are not required > > 3. BuildRoot tag not required unless you want to support RHEL 5. > > > 5. rm -rf $RPM_BUILD_ROOT in %install not needed > > 6. %clean not required unless supporting RHEL 5 > > 8. %defattr(-,root,root) not needed. Everything predetermined. I wish to package it in EPEL5. > > 7. %{!?_licensedir:%global license %doc} -- Have you verified this works? It works of course. http://fedoraproject.org/wiki/EPEL:Packaging#The_.25license_tag > > 9. "%_mandir/mann/tkTable.*" -- Strange that mandir isn't in {} but I guess > it works fine. Some packagers use this form. Changed even if it would have worked in any case. Spec URL: https://sagitter.fedorapeople.org/tktable/tktable.spec SRPM URL: https://sagitter.fedorapeople.org/tktable/tktable-2.10-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review