https://bugzilla.redhat.com/show_bug.cgi?id=1272054 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 3080375bf5f96cb15310d1870a75472dc1fd2371273c6a546b81401b6f674a28). License verified from lib/Roman.pm, README. Ok. Summary verified from lib/Roman.pm. Ok Description verified from lib/Roman.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Constrain `perl(Exporter)' BuildRequires with `>= 5.57' (META.json:39). All tests pass. Ok. $ rpmlint perl-Roman.spec ../SRPMS/perl-Roman-1.24-1.fc24.src.rpm ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm drwxr-xr-x 2 root root 0 Oct 16 09:52 /usr/share/doc/perl-Roman -rw-r--r-- 1 root root 757 Oct 16 09:52 /usr/share/doc/perl-Roman/Changes -rw-r--r-- 1 root root 1395 Oct 16 09:52 /usr/share/doc/perl-Roman/README -rw-r--r-- 1 root root 2145 Oct 16 09:52 /usr/share/man/man3/Roman.3pm.gz -rw-r--r-- 1 root root 3920 Mar 1 2015 /usr/share/perl5/vendor_perl/Roman.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(:VERSION) >= 5.6.0 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Constrain `perl(Exporter)' Requires with `>= 5.57' (META.json:39). $ rpm -q --provides -p ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl(Roman) = 1.24 1 perl-Roman = 1.24-1.fc24 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Roman-1.24-1.fc24.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=11470869). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review