Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-IO-Compress-Bzip2 - IO::Compress interface to bzip2 data https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243016 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-09 01:05 EST ------- Well, crap, I took this and now I can't get to search.cpan.org. Ahh, but I can get to cpan.org. The only thing I can't explicitly test is the Source URL, but it follows the proper format for search.cpan.org and I have no reason to think it isn't correct. Review: * source files match upstream: 81fc6711f7525dfdf23cc6dc8e233d99e98aed449476d6ccca6490334806080f IO-Compress-Bzip2-2.004.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(IO::Compress::Adapter::Bzip2) = 2.004 perl(IO::Compress::Bzip2) = 2.004 perl(IO::Uncompress::Adapter::Bunzip2) = 2.004 perl(IO::Uncompress::Bunzip2) = 2.004 perl-IO-Compress-Bzip2 = 2.004-1.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Compress::Raw::Bzip2) >= 2.004 perl(Exporter) perl(IO::Compress::Adapter::Bzip2) >= 2.004 perl(IO::Compress::Base) >= 2.004 perl(IO::Compress::Base::Common) >= 2.004 perl(IO::Uncompress::Adapter::Bunzip2) >= 2.004 perl(IO::Uncompress::Base) >= 2.004 perl(bytes) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful, 2 subtests skipped. Files=14, Tests=8302, 6 wallclock secs ( 4.84 cusr + 0.63 csys = 5.47 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review