[Bug 1268372] Review Request: openstack-app-catalog-ui - openstack horizon plugin for the openstack app-catalog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1268372



--- Comment #3 from Matthias Runge <mrunge@xxxxxxxxxx> ---
Uhm, sorry!

The comment was definitely wrong here.

Could you please update the spec with something like this?
https://github.com/mrunge/app-catalog-ui/blob/rpm-master/openstack-app-catalog-ui.spec

Since your tests (in %check) do nothing, you could safely remove many
BuildRequirements

Once upstream uses tests, we can add them back and use upstreams unittests.

additional to my proposal, you can safely remove 
Requires: python-scss (as it's a requirement of openstack-dashboard)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]