https://bugzilla.redhat.com/show_bug.cgi?id=1257410 --- Comment #16 from Christopher Meng <i@xxxxxxxx> --- (In reply to Jens Lody from comment #11) > Minor issues: > strange permission of source-file (640) > latest version is now 2015.10.08 I tend to left this bug here because the reviewer is somehow questionable, and upstream releases rapidly. The source TBH is a mess. Upstream even don't know how to correct write makefile. > decription: > "AbcMIDI is a set which contains [...]" > set of what ? Set of programs, will be corrected. > "[...]These programs were developed [...] and has been supported [...]" > Shouldn't it be: "[...] and have been supported (plural)" Will be corrected later, too. > The explicit Provides looks strange to me: > Provides: abcmidi = %{version}-%{release} > Provides: abcmidi%{?_isa} = %{version}-%{release} > can the pakage be arch-dependent and arch-independent the same time ? Because you don't understand them. Michael had explained well. > There are several warnings in the build-log, most likely harmless, but they > might lead to issues: > e.g. > parseabc.c:322:12: warning: cast from pointer to integer of different size > [-Wpointer-to-int-cast] > parseabc.c:1062:1: warning: type of 'maxsize' defaults to 'int' > [-Wimplicit-int] > parseabc.c:1749:24: warning: format '%s' expects argument of type 'char *', > but argument 3 has type 'char **' [-Wformat=] > parseabc.c:1851:1: warning: implicit declaration of function 'appendfield' > [-Wimplicit-function-declaration] > parseabc.c:1316:6: warning: 'parsed' may be used uninitialized in this > function [-Wmaybe-uninitialized] I treat all warnings as normal things, sorry but that's my style, I'm only a user from downstream, if it works, then just put it there. > toabc.c:1491:8: warning: iteration 7u invokes undefined behavior > [-Waggressive-loop-optimizations] fast-math and other flags or just higher optimization levels will cause this issue, I singled this because I've met this for several times. I may repack the cflags. > apart of this, everythings looks fine Thank you. I will upload a new version of RPM soon, but please wait for a few days, to wait for the reviewer get sponsored first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review