https://bugzilla.redhat.com/show_bug.cgi?id=1231444 --- Comment #11 from Raphael Groner <projects.rg@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - License tag is invalid, use GPLv2+ instead of GPL2+ - Add Requires: dbus systemd - Add other missing folders ownership into %files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 27 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/CPUFreqUtility/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/dbus-1/system.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/polkit-1/actions, /usr/share/dbus-1/system-services, /usr/share/dbus-1, /etc/dbus-1, /etc/dbus-1/system.d, /usr/share/polkit-1 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [?]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in CPUFreqUtility-debuginfo => I do not understand this, ignore for now. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. => Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11410359 [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define cmake_build_dir build- cmake [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 1.2.13 starting (python version = 3.4.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.13 INFO: Mock Version: 1.2.13 Finish: chroot init INFO: installing package(s): /home/builder/fedora-review/CPUFreqUtility/results/CPUFreqUtility-1.4.3-1.fc24.x86_64.rpm /home/builder/fedora-review/CPUFreqUtility/results/CPUFreqUtility-debuginfo-1.4.3-1.fc24.x86_64.rpm /home/builder/fedora-review/CPUFreqUtility/results/CPUFreqUtility-debuginfo-1.4.3-1.fc24.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 install /home/builder/fedora-review/CPUFreqUtility/results/CPUFreqUtility-1.4.3-1.fc24.x86_64.rpm /home/builder/fedora-review/CPUFreqUtility/results/CPUFreqUtility-debuginfo-1.4.3-1.fc24.x86_64.rpm /home/builder/fedora-review/CPUFreqUtility/results/CPUFreqUtility-debuginfo-1.4.3-1.fc24.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: CPUFreqUtility-1.4.3-1.fc24.x86_64.rpm CPUFreqUtility-debuginfo-1.4.3-1.fc24.x86_64.rpm CPUFreqUtility-1.4.3-1.fc24.src.rpm CPUFreqUtility.x86_64: I: enchant-dictionary-not-found ru => I do not use russian packages, ignore. CPUFreqUtility.x86_64: W: invalid-license GPL2+ => Use GPLv2+ instead. CPUFreqUtility.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.auth.cpufrequtility.conf => A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config, or maybe better as %config(noreplace), in the spec file. https://fedoraproject.org/wiki/Common_Rpmlint_issues#non-conffile-in-etc CPUFreqUtility.x86_64: W: no-manual-page-for-binary CPUFreqUtility => It's a GUI application, ignore. CPUFreqUtility-debuginfo.x86_64: W: invalid-license GPL2+ CPUFreqUtility.src: W: invalid-license GPL2+ => Use GPLv2+ instead. 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- CPUFreqUtility (rpmlib, GLIBC filtered): kf5-kauth kf5-knotifications libKF5Auth.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Notifications.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Gui.so.5()(64bit) libQt5Widgets.so.5()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) qt5-qtbase rtld(GNU_HASH) CPUFreqUtility-debuginfo (rpmlib, GLIBC filtered): Provides -------- CPUFreqUtility: CPUFreqUtility CPUFreqUtility(x86-64) application() application(CPUFreqUtility.desktop) CPUFreqUtility-debuginfo: CPUFreqUtility-debuginfo CPUFreqUtility-debuginfo(x86-64) Source checksums ---------------- https://github.com/F1ash/CPUFreqUtility/archive/1.4.3.tar.gz : CHECKSUM(SHA256) this package : b6f91ad4fa465bb84f0db4d328a1cb2f15ac49996d84675e2d7d8f0b86d2d878 CHECKSUM(SHA256) upstream package : b6f91ad4fa465bb84f0db4d328a1cb2f15ac49996d84675e2d7d8f0b86d2d878 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -rn CPUFreqUtility-1.4.3-1.fc22.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review