https://bugzilla.redhat.com/show_bug.cgi?id=1268380 Randy Barlow <rbarlow@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbarlow@xxxxxxxxxx --- Comment #2 from Randy Barlow <rbarlow@xxxxxxxxxx> --- Hello Stuart! Like you, I am seeking to become a Fedora package maintainer. As part of that process, I've been asked to review a few other packages. Thus what follows is merely an informal review. Here are a few things I noted while looking at your spec file: 0) In your description, s/difference/different/. Also, most modern English grammatical styles recommend one space in between sentences instead of two (which was the former standard). 1) This is merely a style recommendation from PEP-8 (Python), but I like separating the top sections of the SPEC file by two spaces so things like %build and %install are more visually grouped/separated. That's just an opinion, so feel free to ignore ☺ 2) In the %files section, you should include LICENSE.txt with the %license macro instead of the %doc macro. There are also a few things that rpmlint complains about. I've included a few of them below with my own comments: 0) python-sphinx-theme-bootstrap.src: E: description-line-too-long Your description shouldn't be more than 80 characters wide, but you can break it into multiple lines. 1) python-sphinx-theme-bootstrap.src: E: specfile-error warning: bogus date in %changelog October 3, 2015 doesn't exist ☺ 2) There are a lot of complaints about scripts without shebangs, but the code in question is JavaScript/css/svg that is meant to be interpreted by a web browser so I don't think these complaints from rpmlint make any sense. However, it may make sense to keep these particular files in /usr/share instead of /usr/lib/python* since they are really media files and not Python source files. Good luck! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review