[Bug 1270531] Review Request: gfeedline - Social Networking Client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1270531

Haïkel Guémar <karlthered@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |karlthered@xxxxxxxxx



--- Comment #1 from Haïkel Guémar <karlthered@xxxxxxxxx> ---
All of the following are blockers.
* incorrect BuildRequires
BuildRequires:    python >= 2.6
Should be
BuildRequires: python2-devel python-setuptools
* Incorrect sources url, please read the following guideline
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services
* Drop this include
%include %{_rpmconfigdir}/macros.python
* Do not use %py_libdir but %python2_sitelib
* a lot of unowned directories, please read the following guidelines
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
* No requires on runtime libraries, so your application will fail to run
properly after installation. I think that most of your BuildRequires should be
converted to Requires (after all, there is no test suite to run during package
building)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]