[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1221781

Raphael Groner <projects.rg@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |WONTFIX
              Flags|fedora-review?              |fedora-review-
        Last Closed|                            |2015-10-08 04:33:31



--- Comment #32 from Raphael Groner <projects.rg@xxxxxxxx> ---
You use %license now, but it's still wrong cause of the invalid build
conditional.

> %files
> %if 0%{?rhel} < 7 || 0%{?fedora} < 21
> %license COPYING
> %endif
> %{_pkgdocdir}/
> %exclude %{_pkgdocdir}/html/

It has to be like I posted in comment #29, the macro is not available before
Fedora 21 and all those prior distributions are EOL anyways and EOL stuff does
not count in a review. Please test your stuff before requesting any new review.
Can you see the difference between the above and below?

%files
%if 0%{?rhel} >= 7 || 0%{?fedora}
%license COPYING
%endif
%{_pkgdocdir}/
%exclude %{_pkgdocdir}/html/

I fail to explain it even better and do not want to use rude words.
Unfortunately, I must reject this review now, also because I'm running out of
time with this process. In the hope you can understand my reasons. :-(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]