https://bugzilla.redhat.com/show_bug.cgi?id=1269609 --- Comment #3 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Ok, I'm not going to post the full fedora-review output since there's some things that need fixing, but here's some excerpts. Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions I noticed these were intentional but it may help to describe in comments why the special permissions are necessary (more detail in rpmlint output) - Package contains BR: python2-devel or python3-devel I'm questioning this one, assuming this package is both python 2 and 3 compatible, and you're using %{_python}, then you would want the build requirement to be whichever python is the default for that system. If it's not python3 compatible we'll need to specify python2 everywhere. - Package does not contain duplicates in %files. Note: warning: File listed twice: /etc/ari-backup/ari-backup.conf.yaml See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text If you want to support EPEL 6 the simplest solution is something like this: %if 0%{?rhel} < 7 || 0%{?fedora} < 21 %doc LICENSE.txt %else %license LICENSE.txt %endif Rpmlint ------- Checking: ari-backup-1.0.10-1.fc24.noarch.rpm ari-backup-1.0.10-1.fc24.src.rpm ari-backup.noarch: E: description-line-too-long C A helpful wrapper around rdiff-backup that allows backup jobs to be simple Python modules. ari-backup.noarch: E: no-changelogname-tag ari-backup.noarch: W: conffile-without-noreplace-flag /etc/cron.daily/ari-backup ari-backup.noarch: E: non-readable /etc/ari-backup/jobs.d/ari-backup-remote-lvm-demo 600 ari-backup.noarch: E: non-executable-script /etc/ari-backup/jobs.d/ari-backup-remote-lvm-demo 600 /usr/bin/env ari-backup.noarch: E: non-readable /usr/share/doc/ari-backup/LICENSE.txt 700 ari-backup.noarch: E: non-standard-executable-perm /usr/share/doc/ari-backup/LICENSE.txt 700 ari-backup.noarch: W: spurious-executable-perm /usr/share/doc/ari-backup/LICENSE.txt ari-backup.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/ari-backup/LICENSE.txt ari-backup.noarch: E: non-readable /etc/ari-backup/jobs.d/ari-backup-local-lvm-demo 600 ari-backup.noarch: E: non-executable-script /etc/ari-backup/jobs.d/ari-backup-local-lvm-demo 600 /usr/bin/env ari-backup.noarch: E: non-readable /etc/ari-backup/jobs.d/ari-backup-remote-demo 600 ari-backup.noarch: E: non-executable-script /etc/ari-backup/jobs.d/ari-backup-remote-demo 600 /usr/bin/env ari-backup.noarch: E: non-readable /etc/cron.daily/ari-backup 700 ari-backup.noarch: E: non-standard-executable-perm /etc/cron.daily/ari-backup 700 ari-backup.noarch: E: executable-marked-as-config-file /etc/cron.daily/ari-backup ari-backup.noarch: E: non-standard-dir-perm /etc/ari-backup 700 ari-backup.noarch: E: non-standard-dir-perm /var/lib/ari-backup 700 ari-backup.noarch: E: non-standard-dir-perm /etc/ari-backup/jobs.d 700 ari-backup.noarch: E: non-readable /etc/ari-backup/jobs.d/ari-backup-local-demo 600 ari-backup.noarch: E: non-executable-script /etc/ari-backup/jobs.d/ari-backup-local-demo 600 /usr/bin/env ari-backup.noarch: E: non-standard-dir-perm /usr/share/doc/ari-backup 700 ari-backup.noarch: E: non-readable /usr/share/doc/ari-backup/README.md 700 ari-backup.noarch: E: non-standard-executable-perm /usr/share/doc/ari-backup/README.md 700 ari-backup.noarch: W: spurious-executable-perm /usr/share/doc/ari-backup/README.md ari-backup.noarch: E: non-readable /etc/ari-backup/ari-backup.conf.yaml 600 ari-backup.src: E: description-line-too-long C A helpful wrapper around rdiff-backup that allows backup jobs to be simple Python modules. ari-backup.src: E: no-changelogname-tag Hopefully we can clear these up or justify them (in the case of the permissions). If it's important for the executables to only be readable by root, I wonder if they should be in /usr/sbin instead? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review