https://bugzilla.redhat.com/show_bug.cgi?id=1269609 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069@xxxxxxxxx --- Comment #1 from Richard Shaw <hobbes1069@xxxxxxxxx> --- I'm tempted to take this review but I'm going to be busy until sometime next week. We'll see if anyone else jumps in. Until then, here's some quick feedback on your spec file: What distro & versions are you wanting to support? Unless you're going to go back to RHEL 5 I think a lot of stuff can be removed but I would have to double check the guidelines to be sure for every case. 1. All currently supported versions of Fedora and RHEL 6+ define python_sitelib / python_sitearch: (EPEL 6 machine) $ rpm -E %python_sitelib /usr/lib/python2.6/site-packages 2. Group: tags are optional 3. BuildRoot can be removed 4. rm -rf %{buildroot} in %install is only needed for RHEL < 6 5. %clean is done automatically (only needs to be specified in certain multi-source situations) 6. %defattr(-,root,root,-) is automatic, you only need to specify it for your special cases. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review