[Bug 1268910] Review Request: h2o - HTTP server for HTTP/1.x and HTTP/2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1268910



--- Comment #5 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
> Summary:          An optimized HTTP server with support for HTTP/1.x and HTTP/2

> %description
> H2O is a very fast HTTP server written in C.

Why is %summary longer and more detailed than %description?

Typically, the latter expands on the former:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

Suggestion:

  Summary: HTTP server

  %description
  H2O is a very fast HTTP server written in C. It supports HTTP/1.x and HTTP/2.


> %post
> /sbin/ldconfig
> %systemd_post %{name}.service

> %postun
> /sbin/ldconfig

Running ldconfig here doesn't achieve anything related to this package, because
this package doesn't store any shared lib in runtime linker's search path.


> %doc %{_datarootdir}/doc/%{name}

%_datarootdir is %_datadir, which is /usr/share, and files below /usr/share/doc
are implicitly marked as %doc. See "rpm -E %__docdir_path".

> %doc %{_mandir}/man1/%{name}.1.gz

Same for %_mandir.


> %config(noreplace) %{_sysconfdir}/%{name}/%{name}.conf
> 
> %{_libexecdir}/%{name}/setuidgid

The directories %_sysconfdir/%name and %_libexecdir/%{name} are not included
yet.

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories


Consider pointing the fedora-review tool at this ticket:
fedora-review -b 1268910

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]