[Bug 1234210] Review Request: pdf-stapler - tool for manipulating PDF documents from the command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1234210



--- Comment #19 from Matthias Runge <mrunge@xxxxxxxxxx> ---

> > - there are tests in github repo. it would be great to execute them during
> > package build. It gives you a bit more feedback, if your build works (or not)
> 
> How do I do this? Sorry, I am not a python programmer and this is my first
> package anyway.

you could add something like:

%check
%{__python} setup.py test

to execute tests.

Be careful: build systems are not connected to the net, thus downloading from
pypi doesn't work.

you probably need to sed out requirements:

sed -i 's|"PyPDF2>=1.24"||' setup.py


That has to be done in %prep.

Requirements are handled in rpm anyways, there's no much value in keeping them
tied in python.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]