Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: curl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225671 paul@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@xxxxxxxxxxxx Flag| |needinfo? ------- Additional Comments From paul@xxxxxxxxxxxx 2007-06-08 08:15 EST ------- (In reply to comment #2) > > * The %makeinstall macro should not be used > > (wiki: PackagingGuidelines#MakeInstall) > > cURL won't build without the %makeinstall I've been rolling my own curl packages for older distros and using "make DESTDIR=..." hasn't shown up any problems that I've noticed for a long time - what doesn't build unless you use %makeinstall? If anything, I'd think it'd be a problem introduced by one of the patches. > > Minor: > > * Duplicate BuildRequires: pkgconfig (by libidn-devel) > > I don't think this is something we want to fix, as we are going to have troubles > if the libidn maintainer drops the pkgconfig dependency. Not only that, but the curl spec directly invokes pkg-config and not just implicitly when checking how to build with other libraries. So that's another good reason to keep the buildreq. > > Notes: > > * Requires: openssl is not needed (Wiki: Extras/FullExceptionList) > > Fixed. The exception list is about BuildRequires, not Requires. The Fedora curl package uses the certificate revocation list from the openssl package rather than shipping the version bundled with curl, so I would argue that the runtime dependency on openssl should stay, even though it will be redundant due to autogenerated dynamic library dependencies. (In reply to comment #4) > Hi Ruben, > > (In reply to comment #3) > > Two questions: > > - Could you preserve timestamps when installing files with install -p? > > what install -p do you have in mind? I don't see any in the spec file. Do you > mean those in Makefiles? I think the suggestion is to use something like: make DESTDIR=%{buildroot} INSTALL="%{__install} -p" install so that all instances of "install" called in the Makefiles get the "-p" parameter to preserve the timestamps. > > - Is the static library necessary for some other package, and if not, could > you disable it? > > Not sure whether it is needed or not, but definitely we should get rid of it. > The question is whether to move it to a -static subpackage or to remove it > completely. What's your optionon on it? I'd say to remove it altogether. A few other questions: Does curl-7.14.1-nousr.patch do anything useful? What's curl-7.15.0-curl_config-version.patch for? Without these patches, running autotools during package build wouldn't be necessary Perhaps %ldap_version could be figured out at build time rather than being hard-coded? %define ldap_version %(readlink %{_libdir}/libldap.so | sed 's,.*libldap-\\([0-9.]*\\)\\.so\\..*,\\1,') -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review