[Bug 1266258] Review Request: python-URLObject - A utility class for manipulating URLs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1266258



--- Comment #7 from Pete Walter <walter.pete@xxxxxxxxxx> ---
> Requires:  python-six
> Provides:  python2-urlobject

These two lines currently end up as part of python3-urlobject %description. If
you move them below the main package's BuildRequires and above '%package -n
python3-urlobject' they should start working as expected.

> %{__python2} setup.py install --skip-build --root=$RPM_BUILD_ROOT
> %{__python3} setup.py install --skip-build --prefix=%{_prefix} --root $RPM_BUILD_ROOT

Why is --prefix=%{_prefix} only in one of the lines above? Shouldn't it be in
both (or neither)? Also, we have new %py2_install and %py3_install macros that
wrap this. Might be a good idea to use them instead, as is done in
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]