Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Compress-Raw-Zlib - Perl interface to zlib compression library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243012 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-07 19:15 EST ------- Cool, thanks for that update. * source files match upstream: 0f60879a7b3fa4c6439a67271095d2e1e6d084f3395baa323bd9d405d0bd90ac Compress-Raw-Zlib-2.004.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK (could use an extra "the", I suppose) * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: Zlib.so()(64bit) perl(Compress::Raw::Zlib) = 2.004 perl-Compress-Raw-Zlib = 2.004-1.fc8 = libz.so.1()(64bit) perl >= 0:5.004 perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(Exporter) perl(bytes) perl(constant) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=6, Tests=545, 2 wallclock secs ( 1.85 cusr + 0.10 csys = 1.95 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review