https://bugzilla.redhat.com/show_bug.cgi?id=1264713 --- Comment #12 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- I am basically OK with this package, with 2 exceptions: - %{sum} I don't see any need for this define. IMO, all it does is to decrease readability. Please remove it. - %{srcname} Simiarly to %{sum} I don't see any need for this define. Worse, it is being used at places it doesn't make sense. E.g. programs or libraries won't change their names just because the tarball changed its name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review