https://bugzilla.redhat.com/show_bug.cgi?id=1266011 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hobbes1069@xxxxxxxxx --- Comment #1 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Ok, this is my first ocaml review so I have a few questions... 1. Under the OCaml packaging guidelines I see there should be some macros set[1]: %global _use_internal_dependency_generator 0 %global __find_requires /usr/lib/rpm/ocaml-find-requires.sh %global __find_provides /usr/lib/rpm/ocaml-find-provides.sh Per the example spec file, these should go between BuildRequires and %description. Is there I reason your package doesn't need these? In the requires output from fedora-review I don't see the MD5hash as part of the requirement so I'm thinking you do need this. 2. I Don't see a "make opt" or the test at the top of the spec. Does this library not support byte-code only arches? 3. I assume these are not stripped per the OCaml guidelines[2] because they would not function? ocaml-re.x86_64: W: unstripped-binary-or-object /usr/lib64/ocaml/re/re_str.cmxs ocaml-re.x86_64: W: unstripped-binary-or-object /usr/lib64/ocaml/re/re_glob.cmxs ocaml-re.x86_64: W: unstripped-binary-or-object /usr/lib64/ocaml/re/re_pcre.cmxs ocaml-re.x86_64: W: unstripped-binary-or-object /usr/lib64/ocaml/re/re_posix.cmxs ocaml-re.x86_64: W: unstripped-binary-or-object /usr/lib64/ocaml/re/re.cmxs ocaml-re.x86_64: W: unstripped-binary-or-object /usr/lib64/ocaml/re/re_emacs.cmxs ocaml-re.x86_64: W: unstripped-binary-or-object /usr/lib64/ocaml/re/re_perl.cmxs [1] https://fedoraproject.org/wiki/Packaging:OCaml?rd=Packaging/OCaml#Requires_and_provides [2] https://fedoraproject.org/wiki/Packaging:OCaml?rd=Packaging/OCaml#Stripping_binaries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review