https://bugzilla.redhat.com/show_bug.cgi?id=1265628 --- Comment #5 from Pavel Šimerda (pavlix) <psimerda@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #4) > 1. Drop: > > group: System Environment/Daemons Fixed wrong case. According to guidelines Group seems to be needed for EPEL compatibility, right? I want to make dhcpcd as widely available as possible so I'll be definitely asking for EPEL6 and EPEL7 branches as well. > 2. Source0: http://roy.marples.name/downloads/dhcpcd/dhcpcd-6.9.3.tar.xz > > Better: Source0: > http://roy.marples.name/downloads/dhcpcd/dhcpcd-%{version}.tar.xz Sure. > 3. Reason? Or for fun? > > echo y > echo x Debugging cruft, got rid of it. > 4. find %{buildroot} -name '*.la' -delete > > -> > > find %{buildroot} -name '*.la' -delete -print Not sure why would you need to print those, especially in a way that doesn't suggest what's happening with them. > 5. %config /etc/dhcpcd.conf > > No %config(noreplace)? Definitely. > 6. Please substitute paths with macros, %{_libexecdir}, %{_sbindir}, > %{_datadir}, %{_mandir}. Must have been really tired, sorry. > (In reply to Pavel Šimerda (pavlix) from comment #2) > > (In reply to Christopher Meng from comment #1) > > > I'd packaged this for about 3 years, in the past it works on box of other > > > distros. > > > > So why is it not present in Fedora? Can you contact me on IRC? > > No comment. :) Oh, well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review