https://bugzilla.redhat.com/show_bug.cgi?id=1264686 --- Comment #9 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> --- Two findings not covered by the guidelines: >> Prevent installation of documentation or remove the directory >> automatically created. > # remove htlm doc dir to prevent installation in main packet > rm -rf %{buildroot}%{_docdir}/itpp In the majority of cases, it is more clear and convenient to _move_ such documentation files into $(pwd) and then pass them to a local %doc statement: %install … rm -rf __tmp_doc ; mv %{buildroot}%{_docdir}/itpp $(pwd)/__tmp_doc %files doc … %doc __tmp_doc/* That way you don't risk losing any files installed during make install. And you don't need to clean up the local build dir included via %doc, which may contain files you don't want to be included in the package. > # fix wrong permission for itpp-config > %attr (755,root,root) %{_bindir}/%{name}-config Prefer chmod in %prep or %install as a short-term work-around. And try getting the fix applied upstream. Why not %attr? Well, it's like using a chisel to remove dust. It cannot be denied that %attr works in this case, too, but (755,root,root) is default access permission for all installed executables and directories, and you only want to add +w anyway. Typically one uses %attr for special cases only, such as non-root ownership, setuid/setgid and similar scenarios. And if it were more than one files you needed to fix temporarily, %attr would be overhead and would decrease readability of the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review