https://bugzilla.redhat.com/show_bug.cgi?id=1267036 --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- * Correct the lettercase in your description. `CSS', `Less', `Sass', `JavaScript' and `CoffeeScript'. * Missing a builddep called in the spec file: make * Since you're using the NO_PACKLIST feature, require at least EU::MM 6.76. * Missing builddeps needed for the %check phase: - perl(Fcntl), lib/Mojolicious/Plugin/AssetPack/Asset.pm:5 - perl(IO::File), lib/Mojolicious/Plugin/AssetPack/Asset.pm:6 - perl(Mojo::EventEmitter), lib/Mojolicious/Plugin/AssetPack/Preprocessors.pm:70 - perl(Mojo::UserAgent), lib/Mojolicious/Plugin/AssetPack.pm:26 - perl(Mojolicious::Plugin), lib/Mojolicious/Plugin/AssetPack.pm:3 - perl(POSIX), lib/Mojolicious/Plugin/AssetPack/Preprocessor.pm:19 * Carp is not used anywhere. You may (and should) drop it. * Missing an undetected runtime dependency: - perl(Mojo::UserAgent), lib/Mojolicious/Plugin/AssetPack.pm:26 * I see many tests are skipped due to missing preprocessors. Makes me wonder whether this module actually works for these. You may want to require some or all of them (if available), both at build and runtime. t/coffee.t ..................... skipped: Could not find preprocessors for coffee t/jsx.t ........................ skipped: Could not find preprocessors for jsx t/less.t ....................... skipped: Could not find preprocessors for less t/sass.t ....................... skipped: Could not find preprocessors for sass t/scss-no-cache.t .............. skipped: Could not find preprocessors for scss t/scss.t ....................... skipped: Could not find preprocessors for scss For CoffeeScript it would be the `coffee-script' package. For Jsx... we don't have anything in Fedora, it seems. For Less it would be the `nodejs-less' package. For Sass and Scss it would be the Css::Sass Perl module, not yet packaged. * Consider running the optional POD tests (see t/00-basic.t). * Consider packaging the examples directory as %doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review