https://bugzilla.redhat.com/show_bug.cgi?id=1264661 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Consider excluding dot file using wildcard - This is not a blocker, but you might want to exclude all the dot files in once using: %exclude %{gem_instdir}/.* Of course this might be rather big hammer, so this is just for your consideration. * Exclude .gemspec - Since the .gemspec you are including in the -doc subpackage is not the original one (it is the rewritten version created in %prep section), I would suggest to simply exclude the file from package. * Avoid Bundler dependency - Although the Bundler is working just OK in this case, I would still recommend to avoid this dependency. It is as easy as modify the %check section in this way: sed -i "/require 'bundler/ s/^/#/" spec/spec_helper.rb rspec -rpathname -Ilib spec This might help in case that Fedora is bootstrapped for example. You can build this package sooner and possibly avoid some circular dependencies etc. * Remove unnecessary dependencies - The BR: rubygem(activesupport) is not really needed, since it is pulled in via rubygem(railties) dependency. - In case you decide to avoid the Bundler dependency, you can remove BR: rubygem(bundler) as well. Nevertheless, since all the above are just minor nits, I APPROVE the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review