https://bugzilla.redhat.com/show_bug.cgi?id=1259002 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx Flags| |fedora-review? --- Comment #11 from Kevin Fenzi <kevin@xxxxxxxxx> --- So, you don't really need to mention the test and build scripts licenses. You want to list the license of the files in the binary packages. https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F There's no need to change license version, LGPLv2 is fine, you just want to update the LGPLv2 COPYING file (they updated it when the fsf moved mailing addresses). One other minor thing I noticed from a prelim bit of testing: rudiments.x86_64: W: unused-direct-shlib-dependency /usr/lib64/librudiments-0.53.so.1.0.0 /lib64/libm.so.6 perhaps you don't need to link -lm? I'll go ahead and take this for review now, look for a full review a bit later hopefully today. ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review