[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1264656

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch@xxxxxxxxxx



--- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
Just a few quick points:

* What about test suite?
* How about bundling? This directory looks suspicious: %{gem_instdir}/vendor
* You list several BuildRequires which you definitely don't need ATM, since you
don't execute the test suite.
* We typically try to avoid build time dependency on Bundler as much as
possible. Not sure this will be the case, but its always worth asking.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]