https://bugzilla.redhat.com/show_bug.cgi?id=1266124 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: cea89b47e1f70fa78f55f3c405491ce36d3effd9980f5c5491edffa31aa77153). Ok. License verified from README, ppport.h, and lib/Algorithm/Diff/XS.pm. Ok. Summary verified from lib/Algorithm/Diff/XS.pm. Ok Description is Ok. TODO: I recommend appending to __requires_exclude macro instead of redefining it even if it is the first occurrence in the spec file. The macro could already be initialized in some other macro file. All tests pass. Ok. $ rpmlint perl-Algorithm-Diff-XS.spec ../SRPMS/perl-Algorithm-Diff-XS-0.04-1.fc24.src.rpm ../RPMS/x86_64/perl-Algorithm-Diff-XS-0.04-1.fc24.x86_64.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Algorithm-Diff-XS-0.04-1.fc24.x86_64.rpm drwxr-xr-x 2 root root 0 Sep 24 17:31 /usr/lib64/perl5/vendor_perl/Algorithm drwxr-xr-x 2 root root 0 Sep 24 17:31 /usr/lib64/perl5/vendor_perl/Algorithm/Diff -rw-r--r-- 1 root root 3562 Oct 24 2008 /usr/lib64/perl5/vendor_perl/Algorithm/Diff/XS.pm drwxr-xr-x 2 root root 0 Sep 24 17:31 /usr/lib64/perl5/vendor_perl/auto/Algorithm drwxr-xr-x 2 root root 0 Sep 24 17:31 /usr/lib64/perl5/vendor_perl/auto/Algorithm/Diff drwxr-xr-x 2 root root 0 Sep 24 17:31 /usr/lib64/perl5/vendor_perl/auto/Algorithm/Diff/XS -rwxr-xr-x 1 root root 15416 Sep 24 17:31 /usr/lib64/perl5/vendor_perl/auto/Algorithm/Diff/XS/XS.so drwxr-xr-x 2 root root 0 Sep 24 17:31 /usr/share/doc/perl-Algorithm-Diff-XS -rw-r--r-- 1 root root 571 Oct 24 2008 /usr/share/doc/perl-Algorithm-Diff-XS/Changes -rw-r--r-- 1 root root 1694 Oct 24 2008 /usr/share/doc/perl-Algorithm-Diff-XS/README -rw-r--r-- 1 root root 1870 Sep 24 17:31 /usr/share/man/man3/Algorithm::Diff::XS.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Algorithm-Diff-XS-0.04-1.fc24.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.22()(64bit) 1 perl >= 0:5.006 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Algorithm::Diff) >= 1.19 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Algorithm-Diff-XS-0.04-1.fc24.x86_64.rpm | sort -f | uniq -c 1 perl(Algorithm::Diff::XS) = 0.04 1 perl-Algorithm-Diff-XS = 0.04-1.fc24 1 perl-Algorithm-Diff-XS(x86-64) = 0.04-1.fc24 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Algorithm-Diff-XS-0.04-1.fc24.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=11212636). Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review