https://bugzilla.redhat.com/show_bug.cgi?id=1245932 --- Comment #11 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- New release: Spec file: https://melmorabity.fedorapeople.org/packages/shairplay/shairplay.spec SRPM file: https://melmorabity.fedorapeople.org/packages/shairplay/shairplay-0.9.0-3.20150921git498bc5b.fc22.src.rpm Changes: - Update to latest snapshot - Add missing runtime dependency on Avahi - Add AppData file for AirTV - Move icon to %{_datadir}/icons/hicolor (In reply to William Moreno from comment #9) > 1- You SHOULD include the appdata.xlm file, if so, you must include: Done > 2- Handle the desktop file with > > Requires(post): desktop-file-utils > Requires(postun): desktop-file-utils > > %post > /usr/bin/update-desktop-database &> /dev/null || : > > %postun > /usr/bin/update-desktop-database &> /dev/null || : This is only needed when the desktop file has MimeType keys: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database There's no such key in AirTV desktop file. > 3- You a missing this: > BuildRequires: systemd-units A BR on systemd is enough, according to: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd By the way, only the systemd package carries the systemd RPM macro definitions. > 4- Please use the proposed tools to handle the icons in the package and do > not forget to include: > > %post > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > %postun > if [ $1 -eq 0 ] ; then > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > fi As long as a SVG icon is provided, it will work for all sizes, making bitmap icons useless. Today all desktop environments provided by Fedora support SVG icons. Anyway, I moved the icon to %{_datadir}/icons/hicolor, as recommended by the FreeDesktop specs. > 5- Upstream include a test in the repo: > https://github.com/juhovh/shairplay/tree/master/src/test > > So you must run this in %%check Good catch :). Unfortunately I was unable to run those tests, as if they're not compatible anymore with the latest shairplay API. > 6- Here is a html documentation tha you can include in a airtv-docs > subpackage: > https://github.com/juhovh/shairplay/tree/master/AirTV-Qt/qtsingleapplication/ > doc/html This doc. is related to Qt developement, nor AirTV neither shairplay. > 7- There will be a rpmlint warning about a missing manpage, if can include a > manpage will good, you can create one using the man-editor package available > in repos or writting one with a text editor using the groff format. Not a blocker :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review