https://bugzilla.redhat.com/show_bug.cgi?id=1234210 Matthias Runge <mrunge@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1262470 --- Comment #15 from Matthias Runge <mrunge@xxxxxxxxxx> --- Globe Trotter, could you please: - remove code in comments (like in %prep section) - you should require pyPDF2 like in setup, requiring packages under review is just fine. I added that as depending review. - there are tests in github repo. it would be great to execute them during package build. It gives you a bit more feedback, if your build works (or not) - latest version is 0.3.3, please update; I see, you forgot to add a line in changelog - *I would* separate BuildRequires: python2-devel,python-setuptools into two lines: BuildRequires: python2-devel BuildRequires: python-setuptools - P Stark, Globe Trotter, Fedora is moving to be python3 by default. It would be great to provide a python3 (sub) package as well. P Stark, do you support python3 here, too? - PyPDF2 apparently supports python3 - please remove comments from %files section Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1262470 [Bug 1262470] Review Request: python-PyPDF2 - A pure Python library built as a PDF toolkit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review