[Bug 1259061] Review request: python-securepass - SecurePass Python library & tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1259061



--- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) I see scratch build for EPEL6 succeed after removing defattr(-,root,root,-)
so remove that also.
See http://koji.fedoraproject.org/koji/taskinfo?taskID=11191125

2) As tools are sub-packaged, you can remove tools word from description of
main package that is
from
The tools and python libraries for accessing SecurePass platform.
to
The python library for accessing SecurePass platform.

3) BuildRequires: python-pycurl is not needed as its runtime dependency only.

4) Last, this package need to follow
https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision

Add following just before Name: tag
%global commit0 5fe6a702d5b5f66c1dae4e240bd4c823e82ff5bc
%global shortcommit0 %(c=%{commit0}; echo ${c:0:7})

Then your Source0 will become as
Source0:       
https://github.com/garlsecurity/securepass-tools/archive/%{commit0}.tar.gz#/%{name}-%{shortcommit0}.tar.gz

then last change required is in %prep
%setup -qn securepass-tools-%{commit0}

For your easiness I have fixed above issues and new spec is at
https://pnemade.fedorapeople.org/fedora-work/python-securepass.spec
just add changelog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]