[Bug 1116021] Review Request: rubygem-ruby-prof - a fast ruby profiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1116021

Troy Dawson <tdawson@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tdawson@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |tdawson@xxxxxxxxxx



--- Comment #5 from Troy Dawson <tdawson@xxxxxxxxxx> ---
Hi Steve,
I'll take this, but due to a bug in the spec file, it's failing on my
fedora-review, so I can't do a full review yet.
Can you do three things for me.

1 - Change "rm %{buildroot}%{gem_instdir}/lib/ruby_prof.so" to "rm -f
%{buildroot}%{gem_instdir}/lib/ruby_prof.so"
That will fix my bug.  On rawhide that file isn't there, but a force allows it
go just move along if it isn't there.

2 - Update to the latest version (0.15.8)
This will also fix the license problem, because the license then matches the
gemspec upstream.  You can then remove the comments about it in the spec file.

3 - Ensure all the tests still work with the updated version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]