https://bugzilla.redhat.com/show_bug.cgi?id=1264713 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@xxxxxxxx --- Comment #1 from Christopher Meng <i@xxxxxxxx> --- 1. IMO 3 packages needed: uchardet(bin only), libuchardet(or uchardet-libs), libuchardet-devel(or uchardet-libs-devel). 2. %doc COPYING -> %license COPYING 3. No one from upstream allows you to set version as 0.0.1, use 0.0.0 instead. 4. %description is an encoding detector library, which takes a sequence of bytes in an unknown character encoding without any additional information, and attempts to determine the encoding of the text. Sorry, I can't parse the subject. 5. No static lib please. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review