[Bug 1264700] Review Request: ricochet - Anonymous peer-to-peer instant messaging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1264700



--- Comment #2 from Christopher Meng <i@xxxxxxxx> ---
1.   * There are no servers to compromise or operators to intimidate for your
     information

Why not one line?

2. 
qmake-qt5 DEFINES+=RICOCHET_NO_PORTABLE CONFIG+=release

ue %qmake_qt5.

3. Use macros for paths in %files.

https://github.com/ricochet-im/ricochet/blob/master/packaging/rpm/ricochet.spec#L53?

Don't copy spec in upstream sources, most of them don't know how to do
packaging properly, but least make the software work.

4. install -m 0644 -D -p LICENSE %{buildroot}/%{_docdir}/%{name}/LICENSE
install -m 0644 -D -p AUTHORS.md %{buildroot}/%{_docdir}/%{name}/AUTHORS.md
install -m 0644 -D -p README.md %{buildroot}/%{_docdir}/%{name}/README.md

No, use %doc. Because you must also mark license file as %license.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]