[Bug 1262807] Review Request: php-udan11-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1262807



--- Comment #7 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.  No blocker.

[!]: Latest version is packaged.

     Newer snapshot available

No blocker.



[!]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.

     1) Fix obsoletes issue: W: self-obsoletion php-dmitry-php-sql-parser <
0-0.2 obsoletes php-dmitry-php-sql-parser <= 0-0.2.20150820git1b2988f.fc24

     2) Fix provides: Replace
         Provides:       php-dmitry-php-sql-parser <= %{version}-%{release}
     with
         Provides:       php-dmitry-php-sql-parser = %{version}-%{release}

[!]: Requires correct, justified where necessary.

     Per phpcompatinfo, replace
         Requires:       php-spl
     with
         Requires:       php-pcre

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]