[Bug 1262469] Review Request: php-patchwork-utf8 - Portable and performant UTF-8, Unicode and Grapheme Clusters for PHP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1262469



--- Comment #4 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
(In reply to Remi Collet from comment #3)
> [!]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.
>   => mandatory for ASL 2.0
> 
> Please file an upstream bug and add link in .spec
> 
> Notice: as you have a link to both license texts in file headers, I think it
> is ok to use it as a "source" for the package ("Package does not include
> license text files separate from upstream." doesn't apply in this case). But
> of course, habing upstream file seems the best solution.

Thanks! Updated.

Upstream request: https://github.com/tchwork/utf8/pull/50

Spec diff:
https://github.com/siwinski/rpms/commit/ff7ce3ee4ddc259f69bd62083087f9f2cf2116cc#diff-1



> IN composer.json
>         "classmap": ["src/Normalizer.php"]
> I think this is only a compat file, seems fine to ignore this one.

Yes, that is just a compat file for when the intl extension is not available
but it is specified as a requirement of this package.



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/ff7ce3ee4ddc259f69bd62083087f9f2cf2116cc/php-patchwork-utf8/php-patchwork-utf8.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-patchwork-utf8-1.2.3-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]