https://bugzilla.redhat.com/show_bug.cgi?id=1264546 Jens Lody <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxx --- Comment #3 from Jens Lody <fedora@xxxxxxxxxxx> --- (In reply to Fabiano Fidêncio from comment #2) > Christopher, thanks for jump in the review, I hope you don't mind to answer > a few questions. > > Why "3. Drop Group tags in all packages"? They are not the same, better have > it specified, no? > They are optional on Fedora and not required, only for Epel (not sure for which version), see: https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag : - All current versions of Fedora (and their respective RPM versions) treat the Group tag as optional. Packages may include a Group: field for compatibility with EPEL, but are not required to do so. And they litter the spec-file just more. It's hard to read anyway, because of the amount of sub-packages. By the way: Gustavo please fix the url's for Source0 and Source1, they do not work. What's the cause for keeping the "config"-file locally ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review