https://bugzilla.redhat.com/show_bug.cgi?id=1264546 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@xxxxxxxx --- Comment #1 from Christopher Meng <i@xxxxxxxx> --- I can't sponsor you, but I can give some suggestions. 1. Please include your email in changelog. You can try rpmdev-bumpspec to see what exactly is changelog, obviously the current one is poor. 2. "%define soletta_major 0 %define soletta_minor 0 %define soletta_build 1 %define soletta_release beta5" https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define 3. Drop Group tags in all packages. 4. It's better to put %post(un/trans) after %install/%check but before %files. 5. "This package contains the sysctl linux-micro module for %{name}. The module sets kernel parameters from sysctl.conf files. This service will mimic systemd-sysctl.service and read the settings from '/etc/sysctl.conf' or '/run/sysctl.d', '/etc/sysctl.d', '/usr/local/lib/sysctl.d', '/usr/lib/sysctl.d', '/lib/sysctl.d'. Files are processed in alphabetical order. See http://www.freedesktop.org/software/systemd/man/systemd-sysctl.service.html. " Sorry, we don't use some of these paths. Please remove them. 6. The build log is silent, I could only see GEN * CC * LD * BIN * This makes it impossible to detect if it's been built correctly: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags You must compile packages with %optflags and %__global_ldflags for linking, note these need to be inserted, but not substituted of all flags since you might use some custom flags as well. 7. Drop %defattr(-, root, root, -) 8. %{_includedir}/soletta/* No, you forgot %{_includedir}/soletta/ itself, this will only include files underneath the dir without dir itself. 9. Same as above, %{_datadir}/soletta and %{_libdir}/soletta weren't included, but since different subpackages put files inside, you need to decide on your own. 10. You use %license, but put it in lib%{name}-pin-mux-module-Edison only, that's wrong, you should put it into lib%{name}. (because every subpkg depends on it based on the spec from my view) 11. I don't see any packages with name %{name}, so isn't it better to rename this spec to libsoletta? 12 Last question, do we really need such many subpackages? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review