https://bugzilla.redhat.com/show_bug.cgi?id=1255370 --- Comment #8 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- > Is there a reason for the logic for cases where %{with_bundled}/%{with_debug} > /%{with_check}/%{with_unit_test} might be different to be kept for this .spec > file? Removing them makes the .spec file shorter. So you mean removing whole code wrapped with %{with_*} macros? > I mean, why are we conditionalizing using macros that only ever get assigned > one value in this package? There are no tests at the moment. Once they are there, it will get set to 1. So yes, I could remove the code for unit-test, check and bundled. I keep the code cause it can change over time. And it is faster and easier to set those macro to 1 than copying it from other spec. Besides, some else can update the package, write his own unit-test subpackage/check which does not cover every directory or file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review