[Bug 1260375] Review Request: protozero - Minimalistic protocol buffer decoder and encoder in C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1260375

Marcin Juszkiewicz <mjuszkie@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjuszkie@xxxxxxxxxx



--- Comment #4 from Marcin Juszkiewicz <mjuszkie@xxxxxxxxxx> ---

    There are two license files in archive. One is Apache License 2.0, other is
BSD. test/include/catch.hpp is under Boost License 1.0 so licensing information
needs to be checked - from quick look no other ones are used.

    g++ -c -I. -Iinclude -Itest/include -O2 -g -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1  -fvisibility-inlines-hidden
-std=c++11 -Wall -Wextra -pedantic -Wsign-compare -Wsign-conversion
-Wunused-parameter -Wno-float-equal -O0 -g -fno-inline-functions
test/t/repeated_packed_fixed32/writer_test_cases.cpp -o
test/t/repeated_packed_fixed32/writer_test_cases.o
    In file included from
/usr/include/c++/5.2.1/aarch64-redhat-linux/bits/os_defines.h:39:0,
                     from
/usr/include/c++/5.2.1/aarch64-redhat-linux/bits/c++config.h:482,
                     from /usr/include/c++/5.2.1/iosfwd:38,
                     from /usr/include/c++/5.2.1/ios:38,
                     from /usr/include/c++/5.2.1/istream:38,
                     from /usr/include/c++/5.2.1/sstream:38,
                     from test/include/catch.hpp:72,
                     from test/include/test.hpp:2,
                     from
test/t/repeated_packed_fixed32/writer_test_cases.cpp:2:
    /usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires
compiling with optimization (-O) [-Wcpp]
     #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
        ^

    This warning is due to -O0 from DEBUG_FLAGS in Makefile. Simply adding
empty one in %check gets rid of it:

    %check
    %make_build test CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" DEBUG_FLAGS=

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]