https://bugzilla.redhat.com/show_bug.cgi?id=1255370 --- Comment #6 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- Colin Walters builds some packages on rhel7. RHEL7 has no support for debugging so at least with_debug must be set to 0. At the same time there are no devel/unit-test subpackage, so with_devel is set to 0. On the other hand everything on RHEL is built from bundled deps, so with_bundled is set to 1. I could redefine the logic and test if a given macro is defined instead of testing for 1. I.e.: %if 0%{?fedora} || 0%{?rhel} == 6 %global with_devel 1 %global with_debug 1 %endif and %if 0%{?with_devel:1} %if 0%{?with_bundled:1} %if 0%{?with_unit_test:1} %if 0%{?with_debug:1} This will remove some lines. In most cases it will be like: %if 0%{?fedora} || 0%{?rhel} == 6 %global with_devel 1 %global with_debug 1 %global with_check 1 %global with_unit_test 1 %else %global with_bundled 1 %endif However, don't see any improvement. The aim is to make spec file usable for Fedora and RHEL7 at the same time. So you just copy what is in Fedora into RHEL a keep both spec file in sync as much as possible. The macros adds more control to a packager and mark parts of a code as devel, unit-test and so on. So it is easier to understand what each part of a spec file is used for. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review