Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ppl-0.9 - A modern C++ library providing numerical abstractions https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227669 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-06-06 13:41 EST ------- Created an attachment (id=156374) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156374&action=view) mock build log of ppl-0.9-4 on F-devel i386 (I have not read the previous discussion in detail. Just from having watched the newest spec file...) Some notes: * Static archive - Please explain why you want to include static archives in -devel package first. Usually this must not be done for several reasons (maintainance, security, etc) and if you want to ship static archives (with reasonable reason), split all static archives into different subpackages. * macros - Please use macros. For example, /usr/include should be replaced with %{_includedir} and perhaps /usr/lib won't be useful for x86_64 or ppc64 arch. * Documentation directory - should usually be %{_datadir}/doc/%{name}-%{version} ^^^^^^^^^^^^ - and currently /usr/share/doc/ppl/ is not owned by any package. * defattr - Currently we recommend %defattr(-,root,root,-) * Mockbuild - fails on F-devel i386 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review